Open
Conversation
Export TraceT data constructor
Author
|
Hi @mtth |
Owner
|
Hi @JakubBarta, apologies for the delay. I'm concerned that this change will restrict our ability to evolve the library. For example #13 might have broken clients if they relied on the type's representation. I understand the usefulness of being able to define new instances but I'm not sure what a good solution to allow it is yet. Could you share the instance |
Author
|
Hi @mtth, thanks for the quick reply! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, I'd like to thank you for your great work on this library!
This PR exports the TraceT data constructor, thus allowing for more instances for TraceT to be defined.
The project I'm working on unfortunately doesn't work well with UnliftIO, so I have to define instances for MonadBaseControl IO.